Skip to content

fence_gce: fail immediately with import errors#659

Open
arslan9292 wants to merge 1 commit into
ClusterLabs:mainfrom
arslan9292:fence_gce-fail-when-imports-fail
Open

fence_gce: fail immediately with import errors#659
arslan9292 wants to merge 1 commit into
ClusterLabs:mainfrom
arslan9292:fence_gce-fail-when-imports-fail

Conversation

@arslan9292

@arslan9292 arslan9292 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Previously, if a dependency like httplib2 failed to load due to
a package conflict, the script would silently pass and crash further
down the stack. Now, it explicitly catches the error, prints a clear
log message identifying the broken module and exits immediately
making aware of the dependency issue.

AI: Assisted by Claude

@knet-jenkins

knet-jenkins Bot commented Jul 20, 2026

Copy link
Copy Markdown

Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/fence-agents/job/fence-agents-pipeline/job/PR-659/1/input

@arslan9292
arslan9292 force-pushed the fence_gce-fail-when-imports-fail branch from 776008b to d90bfda Compare July 23, 2026 15:58
@knet-jenkins

knet-jenkins Bot commented Jul 23, 2026

Copy link
Copy Markdown

Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/fence-agents/job/fence-agents-pipeline/job/PR-659/2/input

@arslan9292 arslan9292 changed the title fence_gce: fail immediately with EC_GENERIC_ERROR on import errors fence_gce: fail immediately with import errors Jul 23, 2026
@arslan9292
arslan9292 force-pushed the fence_gce-fail-when-imports-fail branch from d90bfda to 9d072ff Compare July 24, 2026 09:59
@knet-jenkins

knet-jenkins Bot commented Jul 24, 2026

Copy link
Copy Markdown

Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/fence-agents/job/fence-agents-pipeline/job/PR-659/3/input

@arslan9292
arslan9292 force-pushed the fence_gce-fail-when-imports-fail branch from 9d072ff to 99c6f13 Compare July 24, 2026 11:13
@knet-jenkins

knet-jenkins Bot commented Jul 24, 2026

Copy link
Copy Markdown

Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/fence-agents/job/fence-agents-pipeline/job/PR-659/4/input

Previously, if a dependency like `httplib2` failed to load due to
a package conflict, the script would silently pass and crash further
down the stack. Now, it explicitly catches the error, prints a clear
log message identifying the broken module and exits immediately
making aware of the dependency issue.

AI: Assisted by Claude

Signed-off-by: Arslan Ahmad <arahmad@redhat.com>
@arslan9292
arslan9292 force-pushed the fence_gce-fail-when-imports-fail branch from 99c6f13 to 449658a Compare July 25, 2026 17:06
@knet-jenkins

knet-jenkins Bot commented Jul 25, 2026

Copy link
Copy Markdown

Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/fence-agents/job/fence-agents-pipeline/job/PR-659/5/input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant