Dev: ui_sbd: Check sbd health before running 'crm sbd' subcommands#2136
Dev: ui_sbd: Check sbd health before running 'crm sbd' subcommands#2136liangxin1300 wants to merge 1 commit into
Conversation
Call SBD.check_sbd_health() before running: - crm sbd configure - crm sbd device - crm sbd purge Return False if SBD health check fails
d62e126 to
5141b70
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
IMO users should be able to change config or purge the SBD when it is unhealthy. |
They can use |
After considering the scenarios carefully, I still have strong concerns about blocking these subcommands, because it would block administrators from disaster recovery. In case of hardware(disk/network) failure, And it is also counter-productive when users' goal is to purge SBD. When they just want to get rid of SBD, they should not be force to troubleshoot first. |
Call SBD.check_sbd_health() before running:
Return False if SBD health check fails