Skip to content

Fix: Adjust the process of configuring qdevice (bsc#1261884)#2111

Open
liangxin1300 wants to merge 1 commit into
ClusterLabs:masterfrom
liangxin1300:20260507_improve_qdevice
Open

Fix: Adjust the process of configuring qdevice (bsc#1261884)#2111
liangxin1300 wants to merge 1 commit into
ClusterLabs:masterfrom
liangxin1300:20260507_improve_qdevice

Conversation

@liangxin1300

@liangxin1300 liangxin1300 commented May 11, 2026

Copy link
Copy Markdown
Collaborator

This PR is to fix the problems mentioned in: #2112

  • Case 1: Say qdevice is already running when rerunning the qdevice stage in the same cluster
# crm cluster init qdevice --qnetd-hostname server1 -y
INFO: Qdevice is already running on this cluster - will not reconfigure
INFO: Done (log saved to /var/log/crmsh/crmsh.log on sle16-1)
  • Case 2: The maintenance mode check happens before prompting for qdevice parameters
# crm cluster init qdevice
WARNING: Please stop all running resources and try again
WARNING: Or use 'crm -F/--force' option to leverage maintenance mode
WARNING: Understand risks that running RA has no cluster protection while the cluster is in maintenance mode and restarting
INFO: Aborting the configuration change attempt
INFO: Done (log saved to /var/log/crmsh/crmsh.log on sle16-1)
  • Case 3: Don't allow to replace/update qnetd server while the qdevice is running
    Will exit with the same info in case 1.
    The user must remove qdevice then re-added

@liangxin1300
liangxin1300 force-pushed the 20260507_improve_qdevice branch 5 times, most recently from 1d1d44c to 50ea598 Compare May 13, 2026 14:11
@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.34%. Comparing base (e4dd350) to head (5ff9a7b).
⚠️ Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/bootstrap.py 71.42% 4 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 55.32% <83.33%> (+<0.01%) ⬆️
unit 52.27% <70.83%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/constants.py 100.00% <ø> (ø)
crmsh/qdevice.py 97.15% <100.00%> (+0.03%) ⬆️
crmsh/bootstrap.py 87.49% <71.42%> (-0.21%) ⬇️

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liangxin1300 liangxin1300 changed the title Fix: Adjust the process of configuring qdevice Fix: Adjust the process of configuring qdevice (bsc#1261884) May 14, 2026
@liangxin1300
liangxin1300 force-pushed the 20260507_improve_qdevice branch from 50ea598 to e78db7e Compare May 14, 2026 02:33
@liangxin1300
liangxin1300 force-pushed the 20260507_improve_qdevice branch from e78db7e to 5ff9a7b Compare May 14, 2026 09:21
@liangxin1300
liangxin1300 marked this pull request as ready for review May 14, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant