Fix: bootstrap: Remove the unnecessary check#1588
Open
liangxin1300 wants to merge 1 commit into
Open
Conversation
Fix issue ClusterLabs#1587 At this point, the local node must already online, otherwise the previous init_cluster_local will raise exceptions. And this is not related to the join process.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
liangxin1300
marked this pull request as ready for review
October 21, 2024 05:32
Collaborator
|
I think the original behavior is correct. You do not overwrite corosync.conf, and you will not get a new cluster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #1587
At this point, the local node must already online, otherwise the previous init_cluster_local will raise exceptions. And this is not related to the join process.