Lower supported Python floor to 3.10#338
Merged
Merged
Conversation
The >=3.13 requires-python floor was an artifact of the PEP 621 packaging migration (setup.py previously declared no floor); nothing in the codebase or its dependencies needs more than 3.10. Verified by running the full mock-provider suite on 3.10 (94 passed, matching 3.13) — CI now runs the mock suite on both the lowest and highest supported versions. mypy now type-checks against 3.10 so use of newer-stdlib APIs is caught at lint time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
requires-python = ">=3.13"floor was introduced as part of the PEP 621 packaging migration (#PR — setup.py previously declared no floor at all) and reflects the CI matrix rather than any actual language/stdlib requirement: the codebase uses only 3.10-safe constructs (X | Noneunions, builtin generics), and all dependencies (tenacity, pyeventsystem, boto3, azure SDKs, google-api-python-client, openstacksdk, moto 5) support 3.10.This matters downstream: Galaxy supports Python >=3.10 and currently has to pin cloudbridge 3.2.0 on anything below 3.13, which locks those deployments out of the 4.2.0 multipart upload support.
Changes
requires-python>=3.13 → >=3.10; added 3.10/3.11/3.12 trove classifierspy3.10-*)python_versionlowered to 3.10 so newer-stdlib usage is caught at lint timeVerification
tox -e py3.10-mock: 94 passed, 5 skipped — identical to the 3.13 run (includes the multipart driver + object store suites under moto)tox -e mypy(now targeting 3.10): clean, 43 filestox -e lint: cleanNote:
google.api_coreemits a FutureWarning that new releases will stop supporting 3.10 after its EOL (2026-10) — released versions keep working; worth revisiting the floor when Galaxy moves its own.