Tasks/diagnostic tooling - #5
Merged
Merged
Conversation
seeded_event_prices has no `id` column (PK is chain_id, tx_hash, log_index,
asset), so `SELECT MAX(id)` errored ("column id does not exist") every cycle.
The seed pass runs first in run_all, so it aborted the whole valuator before
the ETH/LPT/multi passes ran — pricing stopped and no finalized_at cursors were
written. Use count(*) (append-only table => monotonic change signal), which
fits the BIGINT marker column. Verified end-to-end against a seeded DB.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… path The seed marker (seeded_event_prices row count) was only written after the bulk batch, but the steady-state exit returns early at "no candidates" before that. So the marker was never stored, the change-detector never matched, and the expensive has_seed_candidates EXISTS scan (~4s) ran every 60s cycle anyway. Extract a record_seed_marker helper and call it on both exit paths. Verified end-to-end: the SEED cursor row is now written on the no-candidates path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Move metrics_handler above the test module in daemon http.rs and run cargo fmt --all across the workspace. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Add a GIT_SHA build-arg to the Dockerfile that self-reports as both a
LABEL (git_sha) and ENV var on the runtime image, so a deployed image
answers "which commit is this?" without log archaeology — the exact
question that cost us a cycle when a stale :latest was serving an older
binary. Placed last in the runtime stage so a changed SHA never
invalidates the Rust/FE build cache. Wire it through docker-compose.yml's
build section from a GIT_SHA env var (defaults to "unknown").
Verify a deploy with:
docker image inspect <img> --format '{{.Config.Labels.git_sha}}'
docker exec <container> printenv GIT_SHA # catches stale-:latest
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.