feat(explorer): absolutize locally-cached avatar URLs - #4
Merged
Conversation
The explorer now serves ENS avatars it resolved to image bytes (NFT /
ipfs records) as a root-relative path /api/v1/orchestrators/{addr}/avatar.
Url::parse() fails on a relative URL, so valid_thumbnail_url silently
dropped these, and Discord needs an absolute URL to fetch a thumbnail
server-side anyway.
Absolutize avatar_url against the public EXPLORER_BASE_URL in
get_orchestrator/get_gateway — covering webhook embeds, DMs, and commands
in one place. Absolute http(s) values and unresolved ipfs/eip155 records
pass through unchanged (downstream validation still drops the non-http
ones), so no regression.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explorer now serves ENS avatars it resolved to image bytes (NFT / ipfs records) as a root-relative path /api/v1/orchestrators/{addr}/avatar. Url::parse() fails on a relative URL, so valid_thumbnail_url silently dropped these, and Discord needs an absolute URL to fetch a thumbnail server-side anyway.
Absolutize avatar_url against the public EXPLORER_BASE_URL in get_orchestrator/get_gateway — covering webhook embeds, DMs, and commands in one place. Absolute http(s) values and unresolved ipfs/eip155 records pass through unchanged (downstream validation still drops the non-http ones), so no regression.