Fix: Resolve stuck submissions in remote evaluation scenarios (#4921)#4983
Open
Satyamgupta2365 wants to merge 1 commit into
Open
Fix: Resolve stuck submissions in remote evaluation scenarios (#4921)#4983Satyamgupta2365 wants to merge 1 commit into
Satyamgupta2365 wants to merge 1 commit into
Conversation
- Fixed submission_worker.py: Added proper status update to FINISHED after successful remote evaluation - Fixed remote_submission_worker.py: Added complete submission data handling for remote evaluations - Both workers now correctly save evaluation results, metadata, and logs - Submissions now properly transition from running to finished status - Prevents submissions from getting stuck indefinitely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Submissions in remote evaluation challenges (like MMMU-Benchmark) were getting stuck with "submitted" or "running" status indefinitely, preventing participants from seeing their evaluation results.
Root Cause
The submission worker scripts had critical bugs where successfully completed remote evaluations were not being finalized:
This caused submissions to remain stuck in "running" status with no further updates, leaving participants unable to see their scores.
Solution
Fixed both worker scripts to properly handle successful remote evaluation submissions:
Changes in
scripts/workers/submission_worker.pyFINISHEDafter successful remote evaluationChanges in
scripts/workers/remote_submission_worker.pyTesting
Impact
Files Changed
scripts/workers/submission_worker.pyscripts/workers/remote_submission_worker.py