feat: add AOMIC-PIOP1 dataset support - #26
Open
MarioAderman wants to merge 1 commit into
Open
Conversation
Add support for AOMIC-PIOP1 (ds002785) with 216 healthy adult subjects. - Core module with T1w, DWI, BOLD support (aomic_piop1.py) - Validation config with expected counts from paper - CLI commands: bids-hub aomic piop1 [build|validate|info] - Comprehensive test suite: 19 tests, 93% coverage - Download script with 3 methods (AWS S3, OpenNeuro CLI, subset) - Dataset card and documentation updates Closes CloseChoice#12
Author
|
@CloseChoice @The-Obstacle-Is-The-Way Hey! just a quick win to add this dataset.
Any comments, let me know! |
The-Obstacle-Is-The-Way
pushed a commit
to The-Obstacle-Is-The-Way/neuroimaging-go-brrrr
that referenced
this pull request
Dec 17, 2025
Add support for AOMIC-PIOP1 (ds002785) with 216 healthy adult subjects. - Core module with T1w, DWI, BOLD support (aomic_piop1.py) - Validation config with expected counts from Sci Data paper - CLI commands: bids-hub aomic piop1 [build|validate|info] - Comprehensive test suite: 19 tests, 93% coverage - Download script with 3 methods (AWS S3, OpenNeuro CLI, subset) - Dataset card and documentation updates Closes #12 Original-PR: CloseChoice#26 Co-authored-by: The-Obstacle-Is-The-Way <raymonddaniel@icloud.com>
Collaborator
|
Hey @MarioAderman, Great work here - solid implementation, comprehensive tests, and you followed the existing patterns well. Quick note on a confusing situation: I maintain a fork (The-Obstacle-Is-The-Way/neuroimaging-go-brrrr) that has diverged from this repo with schema changes and validation improvements. I've integrated your AOMIC-PIOP1 work into my fork with full author attribution: The-Obstacle-Is-The-Way@8517c4d This doesn't affect your PR here - that's for @CloseChoice to decide. Just wanted to be transparent and let you know your contribution is already being used. Thanks for the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for AOMIC-PIOP1 dataset (OpenNeuro ds002785) with 216 healthy adult subjects.
Implements Issue #12.
Changes
Core Implementation:
src/bids_hub/datasets/aomic_piop1.py- Dataset module with T1w, DWI, BOLD supportsrc/bids_hub/validation/aomic.py- Validation config (expected counts from Scientific Data paper)bids-hub aomic piop1 [build|validate|info]Testing:
tests/test_aomic_piop1.py- 19 tests with 93% module coverageDocumentation:
docs/dataset-cards/aomic-piop1.md- Complete dataset cardscripts/download_aomic_piop1.sh- Download script with 3 methodsCLAUDE.mdwith AOMIC-PIOP1 commands and schemaIntegration:
__init__.pyfilescoverage.xmlto.gitignoreDataset Details
Testing
make allpassesCloses #12