Skip to content

feat: add AOMIC-PIOP1 dataset support - #26

Open
MarioAderman wants to merge 1 commit into
CloseChoice:mainfrom
MarioAderman:main
Open

feat: add AOMIC-PIOP1 dataset support#26
MarioAderman wants to merge 1 commit into
CloseChoice:mainfrom
MarioAderman:main

Conversation

@MarioAderman

Copy link
Copy Markdown

Description

Add support for AOMIC-PIOP1 dataset (OpenNeuro ds002785) with 216 healthy adult subjects.

Implements Issue #12.

Changes

Core Implementation:

  • src/bids_hub/datasets/aomic_piop1.py - Dataset module with T1w, DWI, BOLD support
  • src/bids_hub/validation/aomic.py - Validation config (expected counts from Scientific Data paper)
  • CLI commands: bids-hub aomic piop1 [build|validate|info]

Testing:

  • tests/test_aomic_piop1.py - 19 tests with 93% module coverage
  • Synthetic BIDS fixture with 3 test subjects (full/minimal/missing)
  • Improved type checking practices (explicit string vs Path assertions)

Documentation:

  • docs/dataset-cards/aomic-piop1.md - Complete dataset card
  • scripts/download_aomic_piop1.sh - Download script with 3 methods
  • Updated CLAUDE.md with AOMIC-PIOP1 commands and schema

Integration:

  • Updated exports in __init__.py files
  • Added coverage.xml to .gitignore

Dataset Details

Testing

  • ✅ All 97 tests pass (78 existing + 19 new)
  • ✅ Type checking: 0 errors (mypy strict)
  • ✅ Linting: 0 errors (ruff)
  • ✅ Formatting: All files formatted
  • make all passes

Closes #12

Add support for AOMIC-PIOP1 (ds002785) with 216 healthy adult subjects.

- Core module with T1w, DWI, BOLD support (aomic_piop1.py)
- Validation config with expected counts from paper
- CLI commands: bids-hub aomic piop1 [build|validate|info]
- Comprehensive test suite: 19 tests, 93% coverage
- Download script with 3 methods (AWS S3, OpenNeuro CLI, subset)
- Dataset card and documentation updates

Closes CloseChoice#12
@MarioAderman

Copy link
Copy Markdown
Author

@CloseChoice @The-Obstacle-Is-The-Way Hey! just a quick win to add this dataset.

Any comments, let me know!

The-Obstacle-Is-The-Way pushed a commit to The-Obstacle-Is-The-Way/neuroimaging-go-brrrr that referenced this pull request Dec 17, 2025
Add support for AOMIC-PIOP1 (ds002785) with 216 healthy adult subjects.

- Core module with T1w, DWI, BOLD support (aomic_piop1.py)
- Validation config with expected counts from Sci Data paper
- CLI commands: bids-hub aomic piop1 [build|validate|info]
- Comprehensive test suite: 19 tests, 93% coverage
- Download script with 3 methods (AWS S3, OpenNeuro CLI, subset)
- Dataset card and documentation updates

Closes #12

Original-PR: CloseChoice#26
Co-authored-by: The-Obstacle-Is-The-Way <raymonddaniel@icloud.com>
@The-Obstacle-Is-The-Way

Copy link
Copy Markdown
Collaborator

Hey @MarioAderman,

Great work here - solid implementation, comprehensive tests, and you followed the existing patterns well.

Quick note on a confusing situation: I maintain a fork (The-Obstacle-Is-The-Way/neuroimaging-go-brrrr) that has diverged from this repo with schema changes and validation improvements. I've integrated your AOMIC-PIOP1 work into my fork with full author attribution:

The-Obstacle-Is-The-Way@8517c4d

This doesn't affect your PR here - that's for @CloseChoice to decide. Just wanted to be transparent and let you know your contribution is already being used.

Thanks for the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dataset] Add AOMIC-PIOP1 (ds002785) - Amsterdam Multimodal MRI (216 subjects)

2 participants