Skip to content

[MAJOR] Update COSMIC API access, add createdb command, improve tests/docs, and remove unused sync - #90

Merged
apeltzer merged 28 commits into
Clinical-Genomics:masterfrom
apeltzer:master
Jun 22, 2026
Merged

[MAJOR] Update COSMIC API access, add createdb command, improve tests/docs, and remove unused sync#90
apeltzer merged 28 commits into
Clinical-Genomics:masterfrom
apeltzer:master

Conversation

@apeltzer

@apeltzer apeltzer commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Hello!

this fixes a few issues with

  • Update COSMIC database API access to use the current endpoint
  • Fix file parsing to handle input formats correctly
  • Improve integration tests: minimal tests run on every PR; COSMIC tests run when credentials are available but are skipped on forks to avoid spurious failures
  • Add createdb command for building databases from local files, bypassing download URLs entirely — as long as you have the raw COSMIC/Mitelman/FusionGDB2 files, you're good (resolves intermittent URL/download issues)
  • Expand documentation
  • Remove the unused sync command (Remove sync #69)

Checklist

  • Specify in detail the change
  • Make sure to follow guidelines in docs when adding database/tool
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README is updated

This version is a

Add LEVEL in parenthesis to the commit message

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@apeltzer apeltzer changed the title Cosmic v104 Support Cosmic v101 Support May 27, 2026
@apeltzer apeltzer changed the title Cosmic v101 Support Improve COSMIC Support, Add more integration tests & local database building May 27, 2026
@apeltzer

Copy link
Copy Markdown
Collaborator Author

@clingen-sthlm maybe ;-)

@apeltzer apeltzer mentioned this pull request May 27, 2026
@apeltzer apeltzer changed the title Improve COSMIC Support, Add more integration tests & local database building [MAJOR] Update COSMIC API access, add createdb command, improve tests/docs, and remove unused sync May 27, 2026
@rannick
rannick self-requested a review May 28, 2026 09:15
Comment thread docs/createdb.md Outdated
Comment thread docs/createdb.md Outdated
Comment thread docs/createdb.md Outdated
apeltzer and others added 4 commits June 2, 2026 13:37
Co-authored-by: Annick Renevey <47788523+rannick@users.noreply.github.com>
Fixed issue FusionGDB2 + made some minor changes on project maintenance

@rannick rannick left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, sorry for the late approval

@apeltzer
apeltzer merged commit 1aeba89 into Clinical-Genomics:master Jun 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants