Move GMFD extreme value filling to "parse GMFD" step - #28
Open
brews wants to merge 3 commits into
Open
Conversation
This fixes an issue where extreme values in GMFD were only cleaned for the ERA5 bias adjustment, and not included in the forecast adjustment.
Member
Author
|
I've cleaned up format, linting, and type checks to the best of my ability. Tests also pass just fine but CI is going to say this fails. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves extreme value cleaning into
scripts/01-parse_gmfd.py, ensuring it's used for all subsequent steps.This fixes an issue where extreme values in GMFD were cleaned only for the ERA5 bias adjustment and not the forecast bias adjustment.
Extreme value filling also happens before regirdding. Previously, it was done after regridding, at the coarser grid resolution. This avoids shuffling our dims around and rechunking.