Fix SCRAM auth: return after do_sasl consumes AuthenticationOk - #1
Merged
Conversation
do_sasl reads frames in its own loop and returns once it sees AuthenticationOk, but do_auth then continued looping and read the following BackendKeyData frame, hitting the catch-all and failing with "unexpected auth message". Sources configured with scram-sha-256 could not authenticate. Return from do_auth immediately after do_sasl succeeds; the post-auth ParameterStatus/BackendKeyData/ReadyForQuery sequence is handled by await_ready_for_query as usual. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes SCRAM-SHA-256 authentication flow in ReplicationConn by ensuring do_auth exits immediately after do_sasl completes (since do_sasl already consumes the AuthenticationOk), preventing subsequent post-auth startup frames (e.g., BackendKeyData) from being misclassified as “unexpected auth message”.
Changes:
- Return early from
do_authafter a successfuldo_saslcall, aligning control flow with how SCRAM messages are consumed. - Preserve the existing post-auth handling path via
await_ready_for_queryforParameterStatus/BackendKeyData/ReadyForQuery.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do_sasl reads frames in its own loop and returns once it sees AuthenticationOk, but do_auth then continued looping and read the following BackendKeyData frame, hitting the catch-all and failing with "unexpected auth message". Sources configured with scram-sha-256 could not authenticate.
Return from do_auth immediately after do_sasl succeeds; the post-auth ParameterStatus/BackendKeyData/ReadyForQuery sequence is handled by await_ready_for_query as usual.