Add peer_id param to log_entries_ext - #120
Merged
Merged
Conversation
Add int32 peer_id = -1 as 4th param to the base virtual log_entries_ext
in log_store.hxx. The default sentinel preserves source compatibility for
all existing callers.
Update in_memory_log_store.{hxx,cxx} to add the matching param (the
example does not use the override keyword, so an explicit update is needed
to avoid a silent stop-overriding).
Update the production call site in handle_append_entries.cxx to pass
p.get_id() so the ClickHouse KeeperLogStore override can identify the
requesting follower peer for the per-peer read-ahead feature.
NuRaft submodule note: this is an in-tree edit in the ClickHouse
ClickHouse-keeper-changelog-readahead worktree. A separate upstream NuRaft
PR will be needed before the submodule pointer can be bumped in the main
repo.
Co-Authored-By: Claude Sonnet (Claude Code) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.