Skip to content

Fix data race on peer config_ in handle_rpc_result #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexey-milovidov merged 1 commit into from
Jun 14, 2026
Merged

Fix data race on peer config_ in handle_rpc_result #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/peer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ void peer::handle_rpc_result( ptr<peer> myself,
"current id %" PRIu64 ", from id %" PRIu64 ". "
"will ignore this response. "
"Currently, stale_resps: %d, response_limit: %d",
config_->get_id(),
get_id(),
cur_rpc_id,
my_rpc_client_id,
stale_resps,
Expand All @@ -139,7 +139,7 @@ void peer::handle_rpc_result( ptr<peer> myself,
p_wn( "[EDGE CASE] too verbose stale RPC response from peer %d, "
"will suppress it from now."
"Currently, stale_resps: %d, response_limit: %d",
config_->get_id(),
get_id(),
stale_resps,
limit );
}
Expand Down Expand Up @@ -189,7 +189,7 @@ void peer::handle_rpc_result( ptr<peer> myself,
reset_stream();
if (last_streamed_log_idx) {
p_in("stop stream mode for peer %d at idx: %" PRIu64 "",
config_->get_id(), last_streamed_log_idx);
get_id(), last_streamed_log_idx);
}
reset_stale_rpc_responses();
reset_bytes_in_flight();
Expand Down Expand Up @@ -217,7 +217,7 @@ void peer::handle_rpc_result( ptr<peer> myself,
"returning error: current id %" PRIu64
", from id %" PRIu64 ". "
"Currently, stale_resps: %d, response_limit: %d",
config_->get_id(),
get_id(),
cur_rpc_id,
my_rpc_client_id,
stale_resps,
Expand All @@ -226,7 +226,7 @@ void peer::handle_rpc_result( ptr<peer> myself,
p_wn( "[EDGE CASE] too verbose stale RPC response from peer %d, "
"will suppress it from now."
"Currently, stale_resps: %d, response_limit: %d",
config_->get_id(),
get_id(),
stale_resps,
limit );
}
Expand Down Expand Up @@ -337,7 +337,7 @@ void peer::reopen(context& ctx, timer_task<int32>::executor& hb_exec) {
hb_task_ = cs_new< timer_task<int32>,
timer_task<int32>::executor&,
int32 >
( hb_exec, config_->get_id(),
( hb_exec, get_id(),
timer_task_type::heartbeat_timer ) ;
p_tr("call peer %d reopen succeeded", get_id());
}
Expand Down
Loading