Fix server crash on sub-monthly diagnostics with registered obs#73
Open
AlexisRenchon wants to merge 2 commits into
Open
Fix server crash on sub-monthly diagnostics with registered obs#73AlexisRenchon wants to merge 2 commits into
AlexisRenchon wants to merge 2 commits into
Conversation
Deploying #72 crashed the server during cache precompute: the AMIP atmos output also carries a daily pr file, available_levels advertises :monthly for daily-native data, and aggregate_var only implemented :native/:seasonal/:annual — the error aborted serve_apps at startup. Three-part fix: - aggregate_var implements :monthly ((year, month) bins) and :daily (calendar-day bins), with labels and regression tests - coupled-mode precompute_dashboard_cache now takes the component's own SimDir (pruned to 1M, read from output_active) instead of re-scanning the raw folder, so it covers exactly what the UI serves, stops tripping over stale loose files ("Time dimension is not in non-decreasing order"), and produces fingerprints that match runtime lookups - per-entry try/catch in precompute: a failed entry is warned and skipped, never fatal — the dashboard falls back to live computation on a miss Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The default_gpcp_obs docstring cross-references to_display_units with @ref; Documenter treats an unresolved cross-reference as fatal, which broke the docs build. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploying #72 crashed the server during startup precompute: the AMIP atmos output also carries a daily
prfile;available_levelsadvertises:monthlyfor daily-native data, butaggregate_varonly implemented:native/:seasonal/:annual→Unknown aggregation level: monthly→serve_apps.jlaborted (andRestart=noleft the app down).Three-part fix:
aggregate_varimplements:monthlyand:daily((year, month) and calendar-day bins, NaN-aware like the existing levels), withaggregation_labelentries and regression tests asserting every advertised level aggregates without throwing.1M, read fromoutput_active, i.e. whatdiscover_componentsbuilt and the UI serves) instead of re-scanning the raw component folder. This also stops the pre-existingTime dimension is not in non-decreasing orderload failures from stale loose files, and makes precompute fingerprints identical to the runtime lookups inevents.jl(they were computed from different file sets before).Validation: full suite passes (125 tests, 8 new).
🤖 Generated with Claude Code