Skip to content

kd_p2 parameter update, and SIF unit change.#1799

Closed
nicobartolomeo wants to merge 8 commits into
CliMA:mainfrom
nicobartolomeo:main
Closed

kd_p2 parameter update, and SIF unit change.#1799
nicobartolomeo wants to merge 8 commits into
CliMA:mainfrom
nicobartolomeo:main

Conversation

@nicobartolomeo

Copy link
Copy Markdown
Collaborator

Purpose

Corrected units (SIF) and parameters (kd_p1) related to SIF calculations
Closes #1790

Content

SIF units: "W m^-2 μm^-1"
kd_p2 to value = 0.0773

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Contributor License Agreement required

The following contributor(s) must sign the CLA before this PR can be merged:

Please visit https://ecodesign.clima.caltech.edu/cla/ to review and sign the CLA.

How to sign: Authenticate with GitHub then click the "I agree" button.

Once completed, re-run the checks on this PR.

Comment thread src/diagnostics/define_diagnostics.jl Outdated
long_name = "Solar Induced Fluorescence",
standard_name = "solar_induced_fluorescence",
units = "W m^-2",
units = "W m^-2 μm^-1",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this also per steradian? or was that integrated out

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This has been updated.

@nicobartolomeo
nicobartolomeo marked this pull request as draft July 13, 2026 20:01
@nicobartolomeo
nicobartolomeo marked this pull request as ready for review July 14, 2026 15:23
@nicobartolomeo
nicobartolomeo marked this pull request as draft July 14, 2026 15:23

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Contributor License Agreement required

The following contributor(s) must sign the CLA before this PR can be merged:

Please visit https://ecodesign.clima.caltech.edu/cla/ to review and sign the CLA.

How to sign: Authenticate with GitHub then click the "I agree" button.

Once completed, re-run the checks on this PR.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Contributor License Agreement required

The following contributor(s) must sign the CLA before this PR can be merged:

Please visit https://ecodesign.clima.caltech.edu/cla/ to review and sign the CLA.

How to sign: Authenticate with GitHub then click the "I agree" button.

Once completed, re-run the checks on this PR.

@nicobartolomeo
nicobartolomeo marked this pull request as ready for review July 14, 2026 15:41
@kmdeck
kmdeck enabled auto-merge (squash) July 14, 2026 16:21
@kmdeck
kmdeck disabled auto-merge July 14, 2026 16:22
@nicobartolomeo
nicobartolomeo enabled auto-merge July 14, 2026 16:25
auto-merge was automatically disabled July 15, 2026 18:25

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in default parameters

2 participants