Missing method for point space field matrix solves#2528
Open
kmdeck wants to merge 2 commits into
Open
Conversation
1 task
imreddyTeja
approved these changes
Jun 29, 2026
imreddyTeja
left a comment
imreddyTeja
left a comment
Member
There was a problem hiding this comment.
It would be good to add a test for this
Member
Author
|
I can try and write a test for this but I dont really understand it, @dennisYatunin had suggested the fix. It had been failing in climaland when we were doing the linear solve, related to an off diagonal block of the Jacobian where both variables were defined on point spaces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The land has an off-diagonal block in the Jacobian which, in a column, corresponds to \partialY\partialX where both Y and X are defined on the same point space. Without defining this method, the linear equation solver fails.