feat: add NavigationHelper for launching navigation apps and handling destinations - #45
Open
ClementBobin wants to merge 2 commits into
Open
feat: add NavigationHelper for launching navigation apps and handling destinations#45ClementBobin wants to merge 2 commits into
ClementBobin wants to merge 2 commits into
Conversation
Contributor
|
Warning Review limit reached
Next review available in: 40 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (31)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Android NavigationHelper utility for launching navigation apps / browser fallbacks and sharing locations, and it reorganizes the Android native helper namespace by moving helpers from dev.kindling.android.natif to dev.kindling.android.helper.natif.
Changes:
- Added
NavigationHelper(destinations, travel modes, app discovery, launch/chooser/browser fallback, sharing). - Updated package declarations of existing Android “natif” helpers to the new
dev.kindling.android.helper.natifnamespace. - (Implicit) Requires updating remaining call sites/imports still referencing the old
dev.kindling.android.natifpackage.
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| android/src/main/kotlin/dev/kindling/android/helper/launcher/NavigationHelper.kt | New navigation/location launching + sharing helper with fallbacks and app discovery. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/AccountHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/AudioHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/BatteryHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/BiometricHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/BluetoothHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/BrightnessHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/CameraHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/ClipboardHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/ConnectivityHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/ContactsHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/DisplayHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/DownloadHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/FileHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/HapticHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/KeystoreHelper.kt | Package moved to dev.kindling.android.helper.natif (impacts consumers/imports). |
| android/src/main/kotlin/dev/kindling/android/helper/natif/LocationHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/NfcHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/NotificationHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/PermissionHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/PowerHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/SensorHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/ShareHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/SmsHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/TelephonyHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/ThermalHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/ToastHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/VibrationHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/WifiHelper.kt | Package moved to dev.kindling.android.helper.natif. |
| android/src/main/kotlin/dev/kindling/android/helper/natif/WindowHelper.kt | Package moved to dev.kindling.android.helper.natif. |
Suppressed comments (1)
android/src/main/kotlin/dev/kindling/android/helper/natif/KeystoreHelper.kt:1
- Le renommage de package
dev.kindling.android.natif→dev.kindling.android.helper.natifn'est pas répercuté partout :android/src/main/kotlin/dev/kindling/android/storage/KEncryptedTokenStore.ktimporte encoredev.kindling.android.natif.{EncryptedData, KeystoreConfig, KeystoreHelper}(lignes 9–11), ce qui cassera la compilation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+244
to
+247
| val chooser = Intent.createChooser(sendIntent, "Partager la position") | ||
| .withTaskFlagIfNeeded(context) | ||
| context.startActivity(chooser) | ||
| } |
Comment on lines
+198
to
+199
| @Suppress("DEPRECATION") | ||
| val candidates = pm.queryIntentActivities(intent, PackageManager.MATCH_DEFAULT_ONLY) |
| try { | ||
| context.startActivity(intent) | ||
| } catch (_: ActivityNotFoundException) { | ||
| context.toastNoApp("Application non installée.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
NavigationHelperutility to simplify launching navigation apps and sharing locations, and reorganizes the codebase by moving all native Android helper files into a new package for better structure and clarity.Navigation features:
NavigationHelperclass (android/src/main/kotlin/dev/kindling/android/helper/launcher/NavigationHelper.kt) that provides utilities for launching navigation apps, sharing locations, choosing travel modes, and handling browser fallbacks. It includes data classes for navigation destinations and apps, and robust error handling.Project structure improvements:
dev.kindling.android.natiftodev.kindling.android.helper.natif, updating their package declarations accordingly. This affects helpers for accounts, audio, battery, biometrics, Bluetooth, brightness, camera, clipboard, connectivity, contacts, display, downloads, files, haptics, keystore, location, NFC, notifications, and permissions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19]