Skip to content

Add comments into config.yml #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShadedJon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add comments into config.yml #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Bastion/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,23 @@ BastionBlock:
material: SPONGE
effectRadius: 10
startScaleFactor: 100
# how much damage done to a bastion when it starts maturing.
finalScaleFactor: 0.2
# how much damage done to a bastion once it matures.
warmUpTime: 86400000
# warmUpTime is in milliseconds
maxBreaksPerMinute: 30
# how many blocks can be placed by a single player in a minute.

@IAPark IAPark Oct 18, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be more accurate to say how many blocks count towards damage to the the Bastion in a minute. It's actually implemented really strangely though and perhaps should be renamed. Internally it's used to calculate a invulnerability time/lockout time for each player.

erosionRatePerDay: 0
# damage done to bastion per day
destroyOnRemove: true
# destroys the bastion block itself if broken by placed blocks if set to true.
blocksToErode: 1
# how many bastions break when a field is breached. set to 0 to destroy all overlapping bastions.

@idoash4 idoash4 Oct 18, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to set this to a negative number if you want all the overlapping bastions to lose durability. Setting this to 0 will cause bastions to be unbreakable. Please fix.

@IAPark IAPark Oct 18, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also refers to the number of blocks damage gets applied to when someone places a block (or maybe also tries to teleport though I think there can only be one blocking field for that in the code), not how many get destroyed when the field is broken.

@idoash4 idoash4 Oct 18, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah your explanation of the setting is much better.

@ttk2 ttk2 Oct 20, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocks to erode shoudl be negative? I need to check that in the live
config, had some complaints earlier this week.

On Sun, Oct 18, 2015 at 2:58 PM, BlackXnt notifications@github.com wrote:

In Bastion/config.yml
#31 (comment):

blocksToErode: 1
+# how many bastions break when a field is breached. set to 0 to destroy all overlapping bastions.

Yeah this is a much better way of explaining it^

—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/Bastion/pull/31/files#r42327089.

@IAPark IAPark Oct 20, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked, but it looks like it. https://github.com/Civcraft/Bastion/blob/master/Bastion/src/isaac/bastion/manager/BastionBlockManager.java#L67

@idoash4 idoash4 Oct 20, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ttk2 I think it was changed back to a negative number after we moved to 1.8: #17 The repo was never updated tho so it will be nice if you can upload the current config we are running.

@ttk2 ttk2 Oct 21, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, should I just pull and then push or do you suggest a different method?

@idoash4 idoash4 Oct 21, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't want to pull the repo you can edit the file through the browser(by clicking on the edit button in the page of the file) and copy-paste what you have on the server, just make sure you keep the yml format right. the outcome will be the same.

EnderPearls:
preventEnderPearl: true
# prevent players not on the bastion group from throwing an enderpearl inside the bastion field.
scaleFac: 1
requireMaturity: true
# requires the bastion to be mature before blocking thrown pearls.