CU-86drpnxv7 - Create a CONTRIBUTING.md file#108
Open
LeonardoDizConde wants to merge 1 commit into
Open
Conversation
Contributor
|
Task linked: CU-86drpnxv7 Create a CONTRIBUTING.md file |
melanke
suggested changes
Mar 22, 2024
melanke
left a comment
melanke
left a comment
Contributor
There was a problem hiding this comment.
this is very very good, better than I expected :D
it just need a few fixes
| ``` | ||
| 2. **Run the Rush Change Command:** | ||
|
|
||
| Use the following command, providing a descriptive message of your alterations, and select the appropriate type of modification: |
Contributor
There was a problem hiding this comment.
It's important to say that if there isn't changes relevant for the users there is no need to add a change message.
|
|
||
| ## GitHub Actions Workflows | ||
|
|
||
| - The [``Check Build and Test``](./.github/workflows/check-build-and-test.yml) workflow runs on every pull request to main branch. This workflow checks if a message was added a message on the change log, checks packages are building, and runs E2E tests. |
| - [PNPM](https://pnpm.io/) as the package manager | ||
| - [ESLint](https://eslint.org/) as the linter | ||
| - [Prettier](https://prettier.io/) as the code formatter | ||
| - [Prettier](https://prettier.io/) as the code formatter |
|
|
||
| ### Cleaning Rush Js Cash | ||
| ```bash | ||
| rush purge |
Contributor
There was a problem hiding this comment.
can you explain why this is necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.