Skip to content

feat: add network magic as an optional init option#53

Open
raulduartep wants to merge 1 commit into
mainfrom
magic-in-init
Open

feat: add network magic as an optional init option#53
raulduartep wants to merge 1 commit into
mainfrom
magic-in-init

Conversation

@raulduartep

Copy link
Copy Markdown
Contributor

No description provided.

@luc10921

luc10921 commented May 8, 2026

Copy link
Copy Markdown
Contributor

As a suggestion, if you want to be clearer, you can also add a TSDoc on the init method to explain that we set validUntilBlock as 100 by default and do a getVersion rpc call to get the networkMagic if not passed

@ixje

ixje commented May 8, 2026

Copy link
Copy Markdown
Member

As a suggestion, if you want to be clearer, you can also add a TSDoc on the init method to explain that we set validUntilBlock as 100 by default and do a getVersion rpc call to get the networkMagic if not passed

to tag along on that, I think it's good to also mention it can throw an RpcError if fetching the network magic over RPC fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants