fix: replace neon-js with neon-core and neon-api dependencies#52
Closed
raulduartep wants to merge 1 commit into
Closed
fix: replace neon-js with neon-core and neon-api dependencies#52raulduartep wants to merge 1 commit into
raulduartep wants to merge 1 commit into
Conversation
raulduartep
requested review from
ixje and
luc10921
and removed request for
ixje
April 13, 2026 20:15
luc10921
reviewed
Apr 13, 2026
Comment on lines
+12
to
+13
| '@typescript-eslint/no-unused-expressions': 'off', | ||
| '@typescript-eslint/no-require-imports': 'off', |
Contributor
There was a problem hiding this comment.
Why are you removing those rules?
Contributor
Author
There was a problem hiding this comment.
These rules were added when I updated the typescript-eslint library. To avoid changing a large portion of the codebase, I’ve disabled them.
Contributor
Author
|
I've closed this PR since it does not seems to fix the main problem with neon-js. I noticed that neon-core also bundle all dependency into it's bundle file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
neon-jsbundles its dependencies into a single file (index.js), it becomes impossible to patch specific libraries. For example, if you try to patch thenoble/hashespackage to use a native version in React Native,neon-jswon’t use the patched version because it relies on its own bundled copy of the library.Another issue this causes is TypeScript conflicts with types exported by
neon-core. For example, if an app usesneon-dappkitand also depends onneon-core, both versions must match exactly. Even if you try to enforce this withoverrides, it won’t work properly becauseneon-dappkitdepends onneon-js, which bundles its own version ofneon-coreinstead of using the one installed in the app.I also removed the
browserfield from package.json, since it’s important to let consumers decide which patches or polyfills to use. For example, in React Native it’s better to usereact-native-quick-cryptoinstead ofcrypto-browserify.