You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is currently not possible to download a contract manifest without having a cpm.yml file present. This should not be a requirement for a command as follows
When trying to download it without using the -N flag, I get the following error: FATA[0000] Config file cpm.yaml not found. Run 'cpm init' to create a default config.
I think it would be nice to also explain the user could use -N instead of creating a config file
When trying to download it without using the -N flag, I get the following error: FATA[0000] Config file cpm.yaml not found. Run 'cpm init' to create a default config. I think it would be nice to also explain the user could use -N instead of creating a config file
What command did you use? -n?
Both -n and -s explicitly state they access cpm.yaml in their command usage descriptions.
./cpm --log-level DEBUG download manifest -c 0x3491b358a9ddce38cb567e2bb8bd1bf783cd556d
I used no network flag, I was thinking that the user might expect it to download from mainnet by default and if they got the error, it would seem like they couldn't use just the terminal without the config file to download it.
Also, do you think we should allow this behaviour with cpm download contract? Or, since it's tied to neoxp files, it would be better to encourage the user to have a cpm.yaml file?
./cpm --log-level DEBUG download manifest -c 0x3491b358a9ddce38cb567e2bb8bd1bf783cd556d I used no network flag
I think in that case it should not work at all. Either -n or -N should be mandatory
Also, do you think we should allow this behaviour with cpm download contract? Or, since it's tied to neoxp files, it would be better to encourage the user to have a cpm.yaml file?
The download contract is really tight to having a local network where it can download to. Making everything an argument is possible, but was not the original intention.
I think in that case it should not work at all. Either -n or -N should be mandatory
Ok, but if they run ./cpm download manifest -c 0x3491b358a9ddce38cb567e2bb8bd1bf783cd556d should the error message be FATA[0000] Config file cpm.yaml not found. Run 'cpm init' to create a default config. with no mentions of the -N flag?
I think in that case it should not work at all. Either -n or -N should be mandatory
Ok, but if they run ./cpm download manifest -c 0x3491b358a9ddce38cb567e2bb8bd1bf783cd556d should the error message be FATA[0000] Config file cpm.yaml not found. Run 'cpm init' to create a default config. with no mentions of the -N flag?
no, I think we need a new message and/or logic that says -n or -N (one of the two) is mandatory. I'll make that part of this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #36 and #37 (review/merge those first)
It is currently not possible to download a contract manifest without having a
cpm.ymlfile present. This should not be a requirement for a command as followsAll I wanted was to download the manifest so I could generate bindings. No storage needed.