Security: close second-order Telegram parsing boundaries - #1
Merged
Conversation
Circe22
marked this pull request as ready for review
September 11, 2026 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R2 security hardening following review of the Telegram Rich Message trust boundary.
This PR fixes four follow-up issues:
attach:///file:semantic checks to actual media/url fields instead of interpreting arbitrary display text;json.loads, including string-formblocksbefore its second parse;media_pathsthey do not upload;Validation is intentionally two-stage. The first PR CI applies the candidate patch in an ephemeral checkout and runs the full Linux 3.9/3.12/3.13 + Windows suite. Only if all jobs pass does a finalize job materialize the exact patch and permanent regressions onto the branch. Temporary bootstrap files/workflow changes will then be removed atomically, followed by a clean CI run on the final tree before merge.