Repository navigation
Pin the Step06 documentation pages and wait longer for Ollama - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Step06 samples download two pages of the Agent Framework documentation from the main branch of MicrosoftDocs/semantic-kernel-docs. On October 23 the pages were removed from main, and both samples stopped at the first download:
_Ollamasamples builtOllamaApiClientfrom a URI, so itsHttpClientgave up after the default 100 seconds. On a CPU a qwen2.5:3b answer can take longer: in these runs, up to 2 min 36 s in Step06 and 4 min 1 s in Step07. The sample then stopped with aTaskCanceledException. Step06, Step07 and Step10 built the client the same way. All three now pass it anHttpClientwith a 10-minute timeout.Tested with Chroma 1.5.9 in Docker:
dotnet test: 10/10.AgentWithRAG_Step06_ChromaRAGwith Microsoft Foundry answers the four questions and cites the pinned pages. The three_Ollamasamples run to the end with qwen2.5:3b and nomic-embed-text. With the pinned pages but without the timeout change, Step06 Ollama stopped on the 100-second timeout in 3 runs out of 3.