Skip to content

Add unit/integration tests, fix uncovered bugs, release 1.0.5 - #1

Open
ChromaBeast wants to merge 3 commits into
mainfrom
claude/app-test-cases-review-2abe94
Open

ChromaBeast wants to merge 3 commits into
mainfrom
claude/app-test-cases-review-2abe94

Conversation

@ChromaBeast

Copy link
Copy Markdown
Owner

Summary

  • Adds ~300 Python tests (mocked units, CLI handlers, real-ffmpeg integration) and Flutter tests for models, app state, scanning and transcoding. 344 Python and 66 Flutter tests pass.
  • Fixes bugs found by the tests:
    • --report x.json wrote HTML instead of JSON
    • --quality-check compared the output file to itself
    • ContentType.UNKNOWN aliased LIVE_ACTION (added preset_key)
    • duplicate finder missed matches across 4s duration buckets
    • report size formatting truncated fractions; report HTML now escapes names
    • content_classifier failed to import on Python 3.9
  • Bumps version to 1.0.5 (Python, Flutter, Windows installer, Linux deb) and also emits a version-less mediacrush_amd64.deb.

Notes

  • Tag v1.0.5 is already pushed and triggers the release workflow.

🤖 Generated with Claude Code

Tests: ~300 new Python tests (mocked units, CLI handlers, real-ffmpeg
integration) and Flutter tests for models, app state, scan and transcode.

Fixes:
- compress --report x.json wrote HTML instead of JSON
- --quality-check compared the output to itself
- ContentType.UNKNOWN aliased LIVE_ACTION; add preset_key mapping
- duplicate finder missed matches across 4s duration buckets
- report size formatting truncated fractions; escape HTML in reports
- content_classifier failed to import on Python 3.9
… installer and Linux deb

Also publish a version-less mediacrush_amd64.deb so the website can link to the latest release.
Copilot AI balanced review requested due to automatic review settings November 5, 2026 09:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T09:47:44.076584Z 5feb65b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants