Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ Npm intellisense scans only dependencies by default. Set scanDevDependencies to
}
```

### Show build in (local) libs
Shows build in node modules like 'path' of 'fs'
### Show built in (local) libs
Shows built in node modules like 'path' or 'fs'

```javascript
{
"npm-intellisense.showBuildInLibs": true,
"npm-intellisense.showBuiltInLibs": true,
}
```

Expand Down
22 changes: 11 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@
"vscode": "^1.0.0"
},
"homepage": "https://github.com/ChristianKohler/NpmIntellisense",
"repository": {
"type": "git",
"url": "https://github.com/ChristianKohler/NpmIntellisense.git"
},
"repository": {
"type": "git",
"url": "https://github.com/ChristianKohler/NpmIntellisense.git"
},
"categories": [
"Other"
],
"activationEvents": [
"onLanguage:typescript",
"onLanguage:javascript",
"onLanguage:javascriptreact",
"onLanguage:typescriptreact",
"onCommand:npm-intellisense.import"
"onLanguage:typescript",
"onLanguage:javascript",
"onLanguage:javascriptreact",
"onLanguage:typescriptreact",
"onCommand:npm-intellisense.import"
],
"contributes": {
"configuration": {
Expand All @@ -42,10 +42,10 @@
"default": false,
"description": "(experimental) Enables path intellisense in subfolders of modules"
},
"npm-intellisense.showBuildInLibs": {
"npm-intellisense.showBuiltInLibs": {
"type": "boolean",
"default": false,
"description": "shows build in node modules like 'path' of 'fs'"
"description": "shows built in node modules like 'path' or 'fs'"
},
"npm-intellisense.importES6": {
"type": "boolean",
Expand Down
10 changes: 5 additions & 5 deletions src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,24 @@ export interface Config {
scanDevDependencies?: boolean,
recursivePackageJsonLookup?: boolean,
packageSubfoldersIntellisense?: boolean,
showBuildInLibs?: boolean,
showBuiltInLibs?: boolean,
importES6?: boolean,
importQuotes?: string,
importLinebreak?: string,
importDeclarationType?: string
}

export function getConfig() : Config {
export function getConfig(): Config {
const configuration = workspace.getConfiguration('npm-intellisense');

return {
scanDevDependencies: configuration['scanDevDependencies'],
recursivePackageJsonLookup: configuration['recursivePackageJsonLookup'],
packageSubfoldersIntellisense: configuration['packageSubfoldersIntellisense'],
showBuildInLibs: configuration['showBuildInLibs'],
showBuiltInLibs: configuration['showBuiltInLibs'],
importES6: configuration['importES6'],
importQuotes:configuration['importQuotes'],
importLinebreak:configuration['importLinebreak'],
importQuotes: configuration['importQuotes'],
importLinebreak: configuration['importLinebreak'],
importDeclarationType: configuration['importDeclarationType']
};
}
4 changes: 2 additions & 2 deletions src/provide.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ export function getNpmPackages(state: State, config: Config, fsf: FsFunctions) {
.then(packageJson => [
...Object.keys(packageJson.dependencies || {}),
...Object.keys(config.scanDevDependencies ? packageJson.devDependencies || {} : {}),
...(config.showBuildInLibs ? getBuildInModules() : [])
...(config.showBuiltInLibs ? getBuiltInModules() : [])
])
.catch(() => []);
}

function getBuildInModules() : string[] {
function getBuiltInModules(): string[] {
return (<any>repl)._builtinLibs;
}

Expand Down
8 changes: 4 additions & 4 deletions test/provide.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { FsFunctions } from '../src/fs-functions';
suite("provide Tests", () => {
test("Should read dependencies", (done: MochaDone) => {
const state = createState();
const config : Config = { };
const config: Config = {};
const fsf = createFsf();

provide(state, config, fsf)
Expand Down Expand Up @@ -38,10 +38,10 @@ suite("provide Tests", () => {
.catch(err => done(err));
});

test("Should show build in node modules when enabled", (done: MochaDone) => {
test("Should show built in node modules when enabled", (done: MochaDone) => {
const state = createState();
const config: Config = {
showBuildInLibs: true
showBuiltInLibs: true
};
const fsf = createFsf();

Expand Down Expand Up @@ -90,7 +90,7 @@ function createFsf(): FsFunctions {
};
}

function readJsonMock(path) : Promise<any> {
function readJsonMock(path): Promise<any> {
switch (path) {
case '/User/dummy/project/src/package.json':
return Promise.resolve({
Expand Down