Skip to content

Fix linux build #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micheldebree merged 2 commits into from
Mar 13, 2026
Merged

Fix linux build #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30703e7
Compiles with `make ubuntu` but doesn't work fully yet
micheldebree Mar 13, 2026
542956e
Made same fix in github build action
micheldebree Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-linux.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Install SDL2
run: sudo apt-get update && sudo apt-get -y install libsdl2-dev
- name: Install Dependencies
run: sudo apt-get update && sudo apt-get -y install libsdl2-dev libjack-jackd2-dev
- name: Build binaries
run: make dist
- name: Upload artifact
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM ubuntu:20.04
ENV DEBIAN_FRONTEND=noninteractive
WORKDIR /home
RUN apt-get update && apt-get -y --no-install-recommends install g++ make git libsdl2-dev
RUN apt-get update && apt-get -y --no-install-recommends install g++ make git libsdl2-dev libjack-jackd2-dev
COPY . .
CMD ["make","dist"]
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ CC_FLAGS=$(shell sdl2-config --cflags) -I$(SOURCE) -D_SF2_$(PLATFORM) -D_BUILD_N
LINKER_FLAGS=$(shell sdl2-config --libs) -lstdc++ -flto

ifeq ($(PLATFORM),LINUX)
CC_FLAGS := $(CC_FLAGS) -DUNIX_JACK
CC_FLAGS := $(CC_FLAGS) -D__UNIX_JACK__
LINKER_FLAGS := $(LINKER_FLAGS) -ljack
endif

Expand Down
Loading