vscode upgrade - #460
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| error(message: string, ...args: any[]) { | ||
| this.outputChannel.appendLine(message); | ||
| this.outputChannel.appendLine(JSON.stringify(args)); | ||
| } |
There was a problem hiding this comment.
Log wrapper ignores log level
Medium Severity
The wrapper’s trace, debug, info, warn, and error methods always append to the output channel and never honor logLevel or VS Code’s log-level filtering. logLevel stays fixed at 0 and onDidChangeLogLevel is never fired, so verbosity cannot match the editor’s log settings.
Reviewed by Cursor Bugbot for commit 0d3fbe6. Configure here.
Implement LogOutputChannelWrapper to match native VS Code log output channels: - Format lines as YYYY-MM-DD HH:mm:ss.SSS [level] message - Respect log level filtering via env.logLevel and onDidChangeLogLevel - Route append/appendLine through info-level logging like the real API - Implement show, hide, replace, clear, and dispose by delegating to the underlying OutputChannel - Format message arguments like VS Code (JSON for objects, stack for errors) Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 027a714. Configure here.
|
|
||
| appendLine(value: string): void { | ||
| this.append(value); | ||
| } |
There was a problem hiding this comment.
Append breaks output channel contract
Medium Severity
LogOutputChannelWrapper routes append and appendLine through info(), so each write is subject to canLog at info level and gets a timestamp, level tag, and forced newline. That differs from a plain OutputChannel (and from native LogOutputChannel legacy writes), so vscode-languageclient output can disappear when the editor log level is above info or look garbled when multiple append calls should form one line.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 027a714. Configure here.
3 participants
Note
Medium Risk
Language client v10 and a custom LogOutputChannel adapter touch core LSP startup/logging; the higher minimum VS Code version drops support for older editors.
Overview
Raises the extension’s minimum VS Code version to ^1.110.0 and bumps
vscode-languageclientto ^10.0.1 (with matching@types/vscodeand lockfile updates for the LSP protocol stack).LogOutputChannelWrapperinlsp.tsadapts a plainOutputChanneltovscode.LogOutputChannel(log levels, timestamps,vscode.env.onDidChangeLogLevel) so the language client’soutputChanneloption stays compatible with v10.Build/test plumbing:
tsconfig.jsonswitches tomodule/moduleResolutionnode16, the Mocha test runner uses a default import, and the code-server test image moves to 4.125.0.Reviewed by Cursor Bugbot for commit 027a714. Bugbot is set up for automated code reviews on this repo. Configure here.