test for duplicate qualities - #117
Open
arvidn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Test-only change with no production code paths modified; may fail CI until duplicate-quality handling is fixed.
Overview
Adds a focused regression test that locks in the invariant that
Prover::get_qualities_for_challenge()must not return duplicatechain_links.The test builds or reuses a deterministic k=18 plot in the temp dir, runs
get_qualities_for_challengewith challenge index 5775 (little-endian in the first 4 bytes of the challenge), and asserts every returned quality has a uniquechain_linksvia aHashSet. Comments document that this challenge currently yields two entries with only one unique chain, so the test is expected to fail until the prover/chainer deduplicates results—complementing the broader duplicate check already intest_plot_roundtrip.Reviewed by Cursor Bugbot for commit 06298d0. Bugbot is set up for automated code reviews on this repo. Configure here.