Conversation
arvidn
changed the title
Pull Request Test Coverage Report for Build 15736984774Details
💛 - Coveralls |
arvidn
marked this pull request as ready for review
June 12, 2025 13:43
Rigidity
previously approved these changes
Jun 12, 2025
Contributor
Author
|
I updated this to not keep reference counts for atoms, since it doesn't seem to be worth memoizing anyway |
Rigidity
previously approved these changes
Jun 17, 2025
…work as substitutes for node_from_bytes_backrefs_record(), which records which nodes are referenced more than once in deserialization. These are used for memoization in tree_hash_cached(). Using reference counters in the Allocator allows memoization of structures generated programmatically as well.
Rigidity
previously approved these changes
Jun 18, 2025
Contributor
Author
|
closed in favor of #589 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These work as substitutes for
node_from_bytes_backrefs_record(), which records which nodes are referenced more than once in deserialization. These are used for memoization in tree_hash_cached(). Using reference counters in the Allocator allows memoization of structures generated programmatically as well.This change makes
node_from_bytes_backrefs_record()obsolete, since the regular deserializer (node_from_bytes_backrefs()) also now records reused nodes.Maintaining reference counts is not free, so this affects the benchmarks:
The benchmarks in
chia_rs(where tree hash is implemented) look like this: