Include dialect in module cache keys

[aqk]

Summary

• Add explicit dialect material, including cse_dominance, to module cache keys.
• Update cache-key tests and module cache fixtures to use the option-aware cache key helper.

Test plan

• cargo test module_cache
• cargo test diskcache

---

Note

Low Risk
Compiler disk-cache keying only; intentional cache invalidation improves correctness without touching runtime auth or data paths.

Overview
Module export disk cache keys now incorporate compiler dialect settings, not just include fingerprints, so cached hex cannot be reused across incompatible compiler configurations.

cache_key takes CompilerOpts, builds module-cache-v2 key material from stepping, strict, int_fix, extra_numeric_constants, and cse_dominance, then appends include fingerprints before hashing. Lookups and writes already had opts; they now feed that into the key. The stable empty-include test expectation changes accordingly, and a new unit test asserts different keys when only cse_dominance toggles. Integration tests resolve .chialisp/<key>/ via the opts-aware module_cache_key_hex helper.

^{Reviewed by Cursor Bugbot for commit 9c21fd1. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 9c21fd1. Configure here.}

[cursor]

Cache key dialect not normalized

Medium Severity

cache_key hashes opts.dialect() as passed into try_from_cache, but module compilation rewrites dialect (int_fix, stepping floor, cse_dominance) before set_cache_element. Lookup and store therefore use different key material, so incremental module disk cache hits fail even when entries exist.

 

^{Reviewed by Cursor Bugbot for commit 9c21fd1. Configure here.}