Per spend counters - #1510
Merged
Merged
Conversation
Contributor
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 368d67a. Configure here.
Coverage Report for CI Build 32773999990Coverage increased (+0.03%) to 82.012%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
AmineKhaldi
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expose atoms and pairs counters per-spend
Note
Low Risk
Additive observability fields on spend metadata with no change to validation rules or consensus behavior; main risk is API breakage for direct callers of SpendConditions::new / process_single_spend.
Overview
Adds
atom_countandpair_counton each spend’s condition metadata so callers can see how many allocator atoms/pairs that spend’s puzzle run created.Spend bundle validation, block generator processing, and fast-forward paths now snapshot the allocator before/after
run_program, compute the delta, and thread those values throughSpendConditions::new/process_single_spend. The owned/Python-facingOwnedSpendConditionsmirror the same fields; fuzz targets, unit tests, and generator test output are updated for the new constructor arguments (paths that don’t execute CLVM pass 0).Reviewed by Cursor Bugbot for commit 368d67a. Bugbot is set up for automated code reviews on this repo. Configure here.