Skip to content

upload .pdb file as release artifact on github - #1506

Merged
arvidn merged 1 commit into
mainfrom
save-debug-info
Aug 21, 2026
Merged

upload .pdb file as release artifact on github#1506
arvidn merged 1 commit into
mainfrom
save-debug-info

Conversation

@arvidn

@arvidn arvidn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
CI-only change for Windows release artifacts. It adds a scoped contents: write job that uploads PDBs to GitHub releases and does not change product, auth, or PyPI packaging logic.

Overview
On Windows release builds, the wheel job now emits line-tables-only debug info so MSVC produces a separate chia_rs.pdb for crash-stack symbolication, without bloating the .pyd or paying extra link time on PR/push.

Those PDBs are zipped per Python/arch (inner name stays chia_rs.pdb so debuggers can match the GUID), uploaded as debug-symbols-* artifacts (not packages-*, so they never hit PyPI), then a small upload-debug-symbols job with contents: write attaches the zips to the GitHub release.

Reviewed by Cursor Bugbot for commit 6166d97. Bugbot is set up for automated code reviews on this repo. Configure here.

@arvidn
arvidn requested a review from AmineKhaldi August 21, 2026 10:48
@arvidn

arvidn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit a5fc588. Configure here.

@arvidn
arvidn enabled auto-merge August 21, 2026 11:13
@arvidn
arvidn disabled auto-merge August 21, 2026 11:21
@arvidn

arvidn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

Comment thread .github/workflows/build-wheels.yml Outdated
@arvidn

arvidn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@arvidn

arvidn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit a814ce7. Configure here.

@arvidn

arvidn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 73b2b77. Configure here.

@arvidn
arvidn marked this pull request as draft August 21, 2026 12:17
@arvidn

arvidn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

Comment thread .github/workflows/build-wheels.yml Outdated
@arvidn

arvidn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 6166d97. Configure here.

@arvidn
arvidn marked this pull request as ready for review August 21, 2026 13:37
@coveralls-official

Copy link
Copy Markdown

Coverage Report for CI Build 32487046951

Coverage remained the same at 81.922%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 20052
Covered Lines: 16427
Line Coverage: 81.92%
Coverage Strength: 11570241.59 hits per line

💛 - Coveralls

@arvidn
arvidn merged commit 6be38c7 into main Aug 21, 2026
85 checks passed
@arvidn
arvidn deleted the save-debug-info branch August 21, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants