Conversation
Coverage Report for CI Build 32455163375Coverage increased (+0.005%) to 81.922%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b949074. Configure here.
AmineKhaldi
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches consensus mempool FF eligibility for relative timelocks. Logic is a small, well-tested flag clear, not a consensus rule change.
Overview
Hardens mempool fast-forward eligibility so a dropped relative timelock (
SkipRelativeCondition) still clearsELIGIBLE_FOR_FF. Those conditions are trivially true (negative “after” or overflowing “before”) but remain relative timelocks.Tests now cover those no-op relative values on ephemeral spends (still
EphemeralRelativeCondition) and confirm they also disqualify FF, while matching absolute skips do not.Reviewed by Cursor Bugbot for commit b949074. Bugbot is set up for automated code reviews on this repo. Configure here.