Skip to content

[CHIA-4364] more hardening of FF logic - #1505

Merged
arvidn merged 1 commit into
mainfrom
harden-ff
Aug 21, 2026
Merged

[CHIA-4364] more hardening of FF logic#1505
arvidn merged 1 commit into
mainfrom
harden-ff

Conversation

@arvidn

@arvidn arvidn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Touches consensus mempool FF eligibility for relative timelocks. Logic is a small, well-tested flag clear, not a consensus rule change.

Overview
Hardens mempool fast-forward eligibility so a dropped relative timelock (SkipRelativeCondition) still clears ELIGIBLE_FOR_FF. Those conditions are trivially true (negative “after” or overflowing “before”) but remain relative timelocks.

Tests now cover those no-op relative values on ephemeral spends (still EphemeralRelativeCondition) and confirm they also disqualify FF, while matching absolute skips do not.

Reviewed by Cursor Bugbot for commit b949074. Bugbot is set up for automated code reviews on this repo. Configure here.

@arvidn
arvidn requested a review from AmineKhaldi August 21, 2026 06:37
@danieljperry danieljperry changed the title more hardening of FF logic [CHIA-4364] more hardening of FF logic Aug 21, 2026
@coveralls-official

Copy link
Copy Markdown

Coverage Report for CI Build 32455163375

Coverage increased (+0.005%) to 81.922%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: 5 of 5 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 20052
Covered Lines: 16427
Line Coverage: 81.92%
Coverage Strength: 11573659.53 hits per line

💛 - Coveralls

@arvidn

arvidn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit b949074. Configure here.

@arvidn
arvidn merged commit 7fe9a89 into main Aug 21, 2026
84 checks passed
@arvidn
arvidn deleted the harden-ff branch August 21, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants