correct transactions_generator_buffer type - #1501
Merged
Merged
Conversation
Contributor
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit de58949. Configure here.
AmineKhaldi
approved these changes
Aug 4, 2026
Coverage Report for CI Build 30916605576Coverage increased (+0.02%) to 81.924%Details
Uncovered Changes
Coverage Regressions3 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a
Vec<u8>right now, which technically is correct, butgenerate_type_stub.pyspecifies allVec<>asList[]. TheBytestype is a thin wrapper aroundVec<u8>meant to be translated tobytesin the python type stubs.This corrects the type of
transactions_generator_bufferto bebytesrather thanList[uint8]. This was the original intention.Note
Low Risk
Refactor of an existing field’s Rust/Python typing and serialization helpers on block types; no new protocol semantics, with roundtrip tests still in place.
Overview
transactions_generator_bufferonFullBlockandUnfinishedBlockis nowOption<Bytes>instead ofOption<Vec<u8>>, so Python stubs exposeOptional[bytes]rather thanlist[uint8].v1 Streamable digest/stream/parse paths delegate to
Bytes’sStreamableimpl instead of hand-rolling length-prefix + raw bytes; wire encoding should stay the same. Rust and Python tests were adjusted (e.g..to_vec()in assertions, v1 helpers passbytesdirectly).Reviewed by Cursor Bugbot for commit de58949. Bugbot is set up for automated code reviews on this repo. Configure here.