make fast forward a bit stricted - #1498
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 337b88e. Configure here.
AmineKhaldi
approved these changes
Jul 29, 2026
Coverage Report for CI Build 30468228464Coverage increased (+0.01%) to 81.829%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Tightens consensus validation for singleton fast-forward; callers that relied on amount changes during fast-forward will now fail, but the change protects mempool cost invariants.
Overview
Singleton fast-forward now rejects spends where the rewritten lineage proof or solution would use different amounts than the target parent/coin, so serialized spend size and run cost stay unchanged.
fast_forward_singletonadds a check thatlineage_proof.parent_amountmatchesnew_parent.amountandnew_solution.amountmatchesnew_coin.amountbefore updating those fields (both are variable-size in CLVM). Integration tests no longer vary parent/coin amounts; they always use the original spend amount, andtest_amount_mismatchcovers mismatches on the new coin and new parent as well as the spent coin.Reviewed by Cursor Bugbot for commit fc59ad5. Bugbot is set up for automated code reviews on this repo. Configure here.