bump k256 and p256 to stable releases - #1486
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Coverage Report for CI Build 29031828155Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 81.938%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Rigidity
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump to from 0.14.0-rc -> 0.14.0
To no longer depend on release candidates
Note
Medium Risk
Touches ECDSA signing dependencies and the prehash signing path; behavior should match stable releases but warrants crypto/signing regression checks.
Overview
Moves workspace k256 and p256 from
0.14.0-rcto0.14.0, withCargo.lockrefreshed for the stable RustCrypto stack (ecdsa,elliptic-curve,signature,rfc6979, and related crates).In chia-secp,
sign_prehashedfor secp256k1 and secp256r1 no longer uses?onsign_prehash_recoverable—the stable API returns the recoverable signature tuple directly, so the wrappers take.0without unwrapping aResult.Reviewed by Cursor Bugbot for commit 495cc15. Bugbot is set up for automated code reviews on this repo. Configure here.