replace v2 plot filter constants for the new filter algorithm - #1484
Merged
Conversation
Contributor
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 72317cb. Configure here.
arvidn
force-pushed
the
v2-plot-filter-constants
branch
from
July 9, 2026 10:56
72317cb to
176b28d
Compare
almogdepaz
approved these changes
Jul 9, 2026
Coverage Report for CI Build 29026707831Coverage remained the same at 81.938%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
Changes consensus constant layout and serialized
ConsensusConstants, which affects proof-of-space eligibility once consumers adopt the new v2 filter algorithm.Overview
Updates
ConsensusConstantsfor the new v2 plot filter schedule: the three placeholderplot_filter_v2_*_adjustment_heightfields are removed and replaced withplot_filter_v2_relative_height(nine heights relative to hard fork 2, last activation first), plusfilter_window_size(16) andmax_effective_plot_filter_bits(13).TEST_CONSTANTS, testDEFAULT_CONSTANTSinrun_gen.py, thetest_consensus_constantsrepr assertion, andchia_rs.pyiare aligned with the new fields and concrete testnet height values.Reviewed by Cursor Bugbot for commit 176b28d. Bugbot is set up for automated code reviews on this repo. Configure here.