Skip to content

replace v2 plot filter constants for the new filter algorithm - #1484

Merged
arvidn merged 1 commit into
mainfrom
v2-plot-filter-constants
Jul 9, 2026
Merged

replace v2 plot filter constants for the new filter algorithm#1484
arvidn merged 1 commit into
mainfrom
v2-plot-filter-constants

Conversation

@arvidn

@arvidn arvidn commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Note

High Risk
Changes consensus constant layout and serialized ConsensusConstants, which affects proof-of-space eligibility once consumers adopt the new v2 filter algorithm.

Overview
Updates ConsensusConstants for the new v2 plot filter schedule: the three placeholder plot_filter_v2_*_adjustment_height fields are removed and replaced with plot_filter_v2_relative_height (nine heights relative to hard fork 2, last activation first), plus filter_window_size (16) and max_effective_plot_filter_bits (13).

TEST_CONSTANTS, test DEFAULT_CONSTANTS in run_gen.py, the test_consensus_constants repr assertion, and chia_rs.pyi are aligned with the new fields and concrete testnet height values.

Reviewed by Cursor Bugbot for commit 176b28d. Bugbot is set up for automated code reviews on this repo. Configure here.

@arvidn

arvidn commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 72317cb. Configure here.

@arvidn
arvidn requested a review from almogdepaz July 9, 2026 10:53
@arvidn
arvidn force-pushed the v2-plot-filter-constants branch from 72317cb to 176b28d Compare July 9, 2026 10:56
@coveralls-official

coveralls-official Bot commented Jul 9, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29026707831

Coverage remained the same at 81.938%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 19671
Covered Lines: 16118
Line Coverage: 81.94%
Coverage Strength: 11506759.94 hits per line

💛 - Coveralls

@arvidn arvidn closed this Jul 9, 2026
@arvidn arvidn reopened this Jul 9, 2026
@arvidn
arvidn enabled auto-merge July 9, 2026 15:08
@arvidn
arvidn merged commit 2fd5715 into main Jul 9, 2026
153 of 154 checks passed
@arvidn
arvidn deleted the v2-plot-filter-constants branch July 9, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants