factor out compute_plot_group_id_v2() and expose it to python - #1479
Merged
Conversation
Coverage Report for CI Build 28596604212Coverage decreased (-0.04%) to 81.484%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
almogdepaz
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Refactor-only extraction of existing v2 hashing with dedicated tests;
compute_plot_id_v2behavior is preserved via delegation.Overview
v2 plot group ID is now a first-class helper:
compute_plot_group_id_v2implementssha256(strength + plot_pk + (pool_pk | contract_ph)), andcompute_plot_id_v2calls it before hashingplot_indexandmeta_group(same formula as before, just split).Python bindings add
compute_plot_group_id_v2in the wheel (api.rs, module registration) with matching stubs ingenerate_type_stubs.py/chia_rs.pyi. New Rust regression tests cover pool-pk and contract-puzzle-hash variants for the group ID.Reviewed by Cursor Bugbot for commit 184b215. Bugbot is set up for automated code reviews on this repo. Configure here.