fix warnings issued by latest version of clippy - #1473
Merged
Conversation
arvidn
force-pushed
the
fix-clippy-warnings
branch
from
June 29, 2026 15:28
7847bf3 to
cfd72dd
Compare
Rigidity
approved these changes
Jun 29, 2026
Coverage Report for CI Build 28433491283Coverage increased (+0.007%) to 81.503%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Style and test assertion refactors only; no production logic changes beyond trivial formatting and a redundant
returnremoval in JSON parsing.Overview
Addresses new Clippy lints repo-wide with mechanical edits only—no intended behavior changes.
Assertions: Tests and fuzz targets swap
assert!(x == y)/assert!(x != y)forassert_eq!/assert_ne!, including flag bitmask checks likeassert_eq!(spend.flags & ELIGIBLE_FOR_DEDUP, 0). Merkle code usesdebug_assert_eq!for duplicate-leaf invariants.Formatting:
Debugimpls for BLSGTElement,PublicKey, andSignatureuse single-lineformat_args!and drop redundant&onhex::encode. Fuzz/tools use inline{var:?}inprintln!/write!where Clippy prefers it.Small cleanups:
Program::from_json_dictdrops a needlessreturnbeforeErr(...). Streamable fuzz compares parse errors withassert_eq!instead ofassert!(expr == Err(...)).Reviewed by Cursor Bugbot for commit cfd72dd. Bugbot is set up for automated code reviews on this repo. Configure here.