Skip to content

fix warnings issued by latest version of clippy - #1473

Merged
arvidn merged 1 commit into
mainfrom
fix-clippy-warnings
Jun 30, 2026
Merged

fix warnings issued by latest version of clippy#1473
arvidn merged 1 commit into
mainfrom
fix-clippy-warnings

Conversation

@arvidn

@arvidn arvidn commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Style and test assertion refactors only; no production logic changes beyond trivial formatting and a redundant return removal in JSON parsing.

Overview
Addresses new Clippy lints repo-wide with mechanical edits only—no intended behavior changes.

Assertions: Tests and fuzz targets swap assert!(x == y) / assert!(x != y) for assert_eq! / assert_ne!, including flag bitmask checks like assert_eq!(spend.flags & ELIGIBLE_FOR_DEDUP, 0). Merkle code uses debug_assert_eq! for duplicate-leaf invariants.

Formatting: Debug impls for BLS GTElement, PublicKey, and Signature use single-line format_args! and drop redundant & on hex::encode. Fuzz/tools use inline {var:?} in println! / write! where Clippy prefers it.

Small cleanups: Program::from_json_dict drops a needless return before Err(...). Streamable fuzz compares parse errors with assert_eq! instead of assert!(expr == Err(...)).

Reviewed by Cursor Bugbot for commit cfd72dd. Bugbot is set up for automated code reviews on this repo. Configure here.

@arvidn
arvidn requested a review from Rigidity June 29, 2026 15:17
@arvidn
arvidn force-pushed the fix-clippy-warnings branch from 7847bf3 to cfd72dd Compare June 29, 2026 15:28
@coveralls-official

coveralls-official Bot commented Jun 29, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 28433491283

Coverage increased (+0.007%) to 81.503%

Details

  • Coverage increased (+0.007%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (31 of 32 lines covered, 96.88%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
crates/chia-bls/src/gtelement.rs 1 0 0.0%
Total (8 files) 32 31 96.88%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 18895
Covered Lines: 15400
Line Coverage: 81.5%
Coverage Strength: 11951446.8 hits per line

💛 - Coveralls

@arvidn arvidn closed this Jun 30, 2026
@arvidn arvidn reopened this Jun 30, 2026
@arvidn
arvidn enabled auto-merge June 30, 2026 09:18
@arvidn
arvidn merged commit b68f2a8 into main Jun 30, 2026
153 of 154 checks passed
@arvidn
arvidn deleted the fix-clippy-warnings branch June 30, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants