Skip to content

Fix/trusted extraction serialization error #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GRYPHON000 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix/trusted extraction serialization error #1444

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
140ff2d
Return error for unserializable trusted block spends
GRYPHON000 May 16, 2026
39c22ad
Update run_block_generator.rs
GRYPHON000 May 16, 2026
c2016f5
Skip unserializable trusted block spends
GRYPHON000 May 16, 2026
65aea87
Return extraction error for unserializable trusted spends
GRYPHON000 May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions crates/chia-consensus/src/run_block_generator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,9 +384,12 @@ where
// This may fail for malicious generators, where the puzzle reveal or
// solution reuses CLVM subtrees such that a plain serialization becomes
// very large. from_clvm() fails if the resulting buffer is greater than
// 2 MB
let puzzle_program = Program::from_clvm(&a, puzzle).unwrap_or_default();
let solution_program = Program::from_clvm(&a, solution).unwrap_or_default();
// 2 MB. Treat this as an extraction failure instead of silently
// substituting Program::default().
let puzzle_program = Program::from_clvm(&a, puzzle)
.map_err(|_| ValidationErr(ErrorCode::GeneratorRuntimeError))?;
let solution_program = Program::from_clvm(&a, solution)
.map_err(|_| ValidationErr(ErrorCode::GeneratorRuntimeError))?;
let coinspend = CoinSpend::new(coin, puzzle_program, solution_program);
output.push(coinspend);
}
Expand Down Expand Up @@ -480,9 +483,12 @@ where
puzhash.into(),
parse_amount(&a, amount, ErrorCode::InvalidCoinAmount)?,
);
let puzzle_program = Program::from_clvm(&a, puzzle).unwrap_or_default();
let solution_program = Program::from_clvm(&a, solution).unwrap_or_default();

// Treat puzzle/solution serialization failure as an extraction failure
// instead of silently substituting Program::default().
let puzzle_program = Program::from_clvm(&a, puzzle)
.map_err(|_| ValidationErr(ErrorCode::GeneratorRuntimeError))?;
let solution_program = Program::from_clvm(&a, solution)
.map_err(|_| ValidationErr(ErrorCode::GeneratorRuntimeError))?;
let Reduction(_clvm_cost, res) = run_program(
&mut a,
&dialect,
Expand Down