more datalayer fuzzers - #1205
Merged
Merged
Conversation
altendky
marked this pull request as draft
August 6, 2025 22:44
altendky
marked this pull request as ready for review
August 7, 2025 20:24
arvidn
approved these changes
Aug 8, 2025
arvidn
left a comment
arvidn
left a comment
Contributor
There was a problem hiding this comment.
Just one nit, I'm sure you're aware of. If get_lineage_blocks_with_indexes() would return an iterator instead, the collect() call could be deferred and you would save some amount of work (heap allocations and copys). It would make the function a bit more complicated, so it may not be worth addressing now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft For: