Skip to content

correct the type stubs for coin_id, parent_id and puzzle_hash #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arvidn merged 1 commit into from
Aug 1, 2025
Merged

correct the type stubs for coin_id, parent_id and puzzle_hash #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_get_puzzle_and_solution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def test_get_puzzle_and_solution_for_coin(input_file: str) -> None:
assert arg.pair is not None
amount = arg.pair[0].atom
assert amount is not None
addition = (ph, int.from_bytes(amount, byteorder="big"))
addition = (bytes32(ph), int.from_bytes(amount, byteorder="big"))
assert addition in expected_additions
expected_additions.remove(addition)

Expand Down
8 changes: 4 additions & 4 deletions tests/test_streamable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
sk = AugSchemeMPL.key_gen(bytes32.random(rng))
pk = sk.get_g1()

coin = b"bcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbc"
parent = b"edededededededededededededededed"
ph = b"abababababababababababababababab"
ph2 = b"cdcdcdcdcdcdcdcdcdcdcdcdcdcdcdcd"
coin = bytes32(b"bcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbc")
parent = bytes32(b"edededededededededededededededed")
ph = bytes32(b"abababababababababababababababab")
ph2 = bytes32(b"cdcdcdcdcdcdcdcdcdcdcdcdcdcdcdcd")


def test_hash_spend() -> None:
Expand Down
8 changes: 4 additions & 4 deletions wheel/generate_type_stubs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,17 +538,17 @@ def make_v2(s: int) -> PlotSize: ...
file,
"SpendConditions",
[
"coin_id: bytes",
"parent_id: bytes",
"puzzle_hash: bytes",
"coin_id: bytes32",
"parent_id: bytes32",
"puzzle_hash: bytes32",
"coin_amount: int",
"height_relative: Optional[int]",
"seconds_relative: Optional[int]",
"before_height_relative: Optional[int]",
"before_seconds_relative: Optional[int]",
"birth_height: Optional[int]",
"birth_seconds: Optional[int]",
"create_coin: list[tuple[bytes, int, Optional[bytes]]]",
"create_coin: list[tuple[bytes32, int, Optional[bytes]]]",
"agg_sig_me: list[tuple[G1Element, bytes]]",
"agg_sig_parent: list[tuple[G1Element, bytes]]",
"agg_sig_puzzle: list[tuple[G1Element, bytes]]",
Expand Down
18 changes: 9 additions & 9 deletions wheel/python/chia_rs/chia_rs.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,17 +318,17 @@ class PrivateKey:

@final
class SpendConditions:
coin_id: bytes
parent_id: bytes
puzzle_hash: bytes
coin_id: bytes32
parent_id: bytes32
puzzle_hash: bytes32
coin_amount: int
height_relative: Optional[int]
seconds_relative: Optional[int]
before_height_relative: Optional[int]
before_seconds_relative: Optional[int]
birth_height: Optional[int]
birth_seconds: Optional[int]
create_coin: list[tuple[bytes, int, Optional[bytes]]]
create_coin: list[tuple[bytes32, int, Optional[bytes]]]
agg_sig_me: list[tuple[G1Element, bytes]]
agg_sig_parent: list[tuple[G1Element, bytes]]
agg_sig_puzzle: list[tuple[G1Element, bytes]]
Comment thread
jack60612 marked this conversation as resolved.
Expand All @@ -351,7 +351,7 @@ class SpendConditions:
before_seconds_relative: Optional[int],
birth_height: Optional[int],
birth_seconds: Optional[int],
create_coin: Sequence[tuple[bytes, int, Optional[bytes]]],
create_coin: Sequence[tuple[bytes32, int, Optional[bytes]]],
agg_sig_me: Sequence[tuple[G1Element, bytes]],
agg_sig_parent: Sequence[tuple[G1Element, bytes]],
agg_sig_puzzle: Sequence[tuple[G1Element, bytes]],
Expand Down Expand Up @@ -380,17 +380,17 @@ class SpendConditions:
def to_json_dict(self) -> dict[str, Any]: ...
@classmethod
def from_json_dict(cls, json_dict: dict[str, Any]) -> Self: ...
def replace(self, *, coin_id: Union[ bytes, _Unspec] = _Unspec(),
parent_id: Union[ bytes, _Unspec] = _Unspec(),
puzzle_hash: Union[ bytes, _Unspec] = _Unspec(),
def replace(self, *, coin_id: Union[ bytes32, _Unspec] = _Unspec(),
parent_id: Union[ bytes32, _Unspec] = _Unspec(),
puzzle_hash: Union[ bytes32, _Unspec] = _Unspec(),
coin_amount: Union[ int, _Unspec] = _Unspec(),
height_relative: Union[ Optional[int], _Unspec] = _Unspec(),
seconds_relative: Union[ Optional[int], _Unspec] = _Unspec(),
before_height_relative: Union[ Optional[int], _Unspec] = _Unspec(),
before_seconds_relative: Union[ Optional[int], _Unspec] = _Unspec(),
birth_height: Union[ Optional[int], _Unspec] = _Unspec(),
birth_seconds: Union[ Optional[int], _Unspec] = _Unspec(),
create_coin: Union[ list[tuple[bytes, int, Optional[bytes]]], _Unspec] = _Unspec(),
create_coin: Union[ list[tuple[bytes32, int, Optional[bytes]]], _Unspec] = _Unspec(),
agg_sig_me: Union[ list[tuple[G1Element, bytes]], _Unspec] = _Unspec(),
agg_sig_parent: Union[ list[tuple[G1Element, bytes]], _Unspec] = _Unspec(),
agg_sig_puzzle: Union[ list[tuple[G1Element, bytes]], _Unspec] = _Unspec(),
Expand Down
Loading