Skip to content

Port check_time_locks() to Rust and pyo3 - #1158

Merged
arvidn merged 28 commits into
mainfrom
check_time_locks
Aug 5, 2025
Merged

Port check_time_locks() to Rust and pyo3#1158
arvidn merged 28 commits into
mainfrom
check_time_locks

Conversation

@matt-o-how

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls-official

coveralls-official Bot commented Jul 17, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 16752516342

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 147 of 188 (78.19%) changed or added relevant lines in 4 files are covered.
  • 237 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.4%) to 66.234%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-consensus/src/owned_conditions.rs 0 2 0.0%
wheel/src/api.rs 0 4 0.0%
crates/chia-protocol/src/coin_record.rs 0 17 0.0%
crates/chia-consensus/src/check_time_locks.rs 147 165 89.09%
Files with Coverage Reduction New Missed Lines %
crates/chia-tools/src/visit_spends.rs 1 0.0%
crates/clvm-utils/src/tree_hash.rs 6 95.88%
crates/chia-consensus/src/validation_error.rs 11 24.32%
crates/chia-protocol/src/spend_bundle.rs 16 72.77%
crates/chia-consensus/src/build_compressed_block.rs 18 80.9%
crates/chia-protocol/src/program.rs 74 27.24%
wheel/src/api.rs 111 0.0%
Totals Coverage Status
Change from base Build 16270565797: 0.4%
Covered Lines: 11689
Relevant Lines: 17648

💛 - Coveralls

@matt-o-how
matt-o-how requested a review from wjblanke July 21, 2025 09:23
@matt-o-how
matt-o-how marked this pull request as ready for review July 21, 2025 09:23
wjblanke
wjblanke previously approved these changes Jul 22, 2025

@wjblanke wjblanke left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

Comment thread crates/chia-consensus/src/check_time_locks.rs Outdated
Comment thread crates/chia-consensus/src/check_time_locks.rs Outdated
Comment thread crates/chia-protocol/src/coin_record.rs

@arvidn arvidn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the coin_state() function probably should be removed

Comment thread crates/chia-consensus/src/check_time_locks.rs
Comment thread crates/chia-consensus/src/check_time_locks.rs Outdated
Comment thread crates/chia-protocol/src/coin_record.rs
Comment thread crates/chia-protocol/src/coin_record.rs
Comment thread crates/chia-consensus/src/check_time_locks.rs Outdated
Comment thread crates/chia-consensus/src/check_time_locks.rs Outdated
Comment thread crates/chia-consensus/src/check_time_locks.rs Outdated
Comment thread crates/chia-consensus/src/check_time_locks.rs Outdated
Comment thread crates/chia-protocol/src/coin_record.rs
Comment thread crates/chia-consensus/src/check_time_locks.rs Outdated
Comment thread crates/chia-consensus/src/check_time_locks.rs
Comment thread crates/chia-consensus/src/check_time_locks.rs
Comment thread crates/chia-consensus/src/check_time_locks.rs Outdated
Comment thread crates/chia-consensus/src/check_time_locks.rs
@arvidn
arvidn merged commit eaed01e into main Aug 5, 2025
60 checks passed
@arvidn
arvidn deleted the check_time_locks branch August 5, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants