-
Notifications
You must be signed in to change notification settings - Fork 266
Say so when a verified NFT video cannot be decoded #3063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jlobue10
wants to merge
3
commits into
Chia-Network:release/2.7.4
Choose a base branch
from
jlobue10:feat/nft-unplayable-media-notice
base: release/2.7.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| import probeMediaPlayability, { resetMediaPlayabilityVerdicts } from './probeMediaPlayability'; | ||
|
|
||
| type FakeMediaElement = HTMLVideoElement & { | ||
| emit: (event: string) => void; | ||
| loadCalls: number; | ||
| }; | ||
|
|
||
| // the tests run without a DOM, so a fake element stands in for the probe's | ||
| // <video>/<audio> and its events are driven by hand | ||
| function fakeMediaElement(errorCode?: number): FakeMediaElement { | ||
| const listeners = new Map<string, Set<() => void>>(); | ||
| const element = { | ||
| error: errorCode === undefined ? null : { code: errorCode }, | ||
| loadCalls: 0, | ||
| preload: '', | ||
| muted: false, | ||
| src: '', | ||
| addEventListener: (event: string, listener: () => void) => { | ||
| if (!listeners.has(event)) { | ||
| listeners.set(event, new Set()); | ||
| } | ||
| listeners.get(event)!.add(listener); | ||
| }, | ||
| removeEventListener: (event: string, listener: () => void) => { | ||
| listeners.get(event)?.delete(listener); | ||
| }, | ||
| removeAttribute: () => {}, | ||
| load: () => { | ||
| element.loadCalls += 1; | ||
| }, | ||
| emit: (event: string) => { | ||
| listeners.get(event)?.forEach((listener) => listener()); | ||
| }, | ||
| } as unknown as FakeMediaElement; | ||
|
|
||
| return element; | ||
| } | ||
|
|
||
| function probe(element: FakeMediaElement, src: string, kind: 'video' | 'audio' = 'video', options = {}) { | ||
| return probeMediaPlayability(src, kind, { createElement: () => element, ...options }); | ||
| } | ||
|
|
||
| describe('probeMediaPlayability', () => { | ||
| beforeEach(() => { | ||
| resetMediaPlayabilityVerdicts(); | ||
| jest.useRealTimers(); | ||
| }); | ||
|
|
||
| it('reports a file whose metadata loads as playable', async () => { | ||
| const element = fakeMediaElement(); | ||
|
|
||
| const verdict = probe(element, 'cache://h264'); | ||
| expect(element.preload).toBe('metadata'); | ||
| expect(element.src).toBe('cache://h264'); | ||
| element.emit('loadedmetadata'); | ||
|
|
||
| await expect(verdict).resolves.toBe('playable'); | ||
| }); | ||
|
|
||
| it('reports a source the media pipeline cannot decode as unsupported', async () => { | ||
| const element = fakeMediaElement(4 /* MEDIA_ERR_SRC_NOT_SUPPORTED */); | ||
|
|
||
| const verdict = probe(element, 'cache://hevc'); | ||
| element.emit('error'); | ||
|
|
||
| await expect(verdict).resolves.toBe('unsupported'); | ||
| }); | ||
|
|
||
| it('reports a decode failure as unsupported', async () => { | ||
| const element = fakeMediaElement(3 /* MEDIA_ERR_DECODE */); | ||
|
|
||
| const verdict = probe(element, 'cache://corrupt', 'audio'); | ||
| element.emit('error'); | ||
|
|
||
| await expect(verdict).resolves.toBe('unsupported'); | ||
| }); | ||
|
|
||
| it('does not blame the file for a network error', async () => { | ||
| const element = fakeMediaElement(2 /* MEDIA_ERR_NETWORK */); | ||
|
|
||
| const verdict = probe(element, 'cache://gone'); | ||
| element.emit('error'); | ||
|
|
||
| await expect(verdict).resolves.toBe('unknown'); | ||
| }); | ||
|
|
||
| it('gives up as unknown when the element never reports', async () => { | ||
| jest.useFakeTimers(); | ||
|
|
||
| const verdict = probe(fakeMediaElement(), 'cache://silent', 'video', { timeout: 1000 }); | ||
| jest.advanceTimersByTime(1000); | ||
|
|
||
| await expect(verdict).resolves.toBe('unknown'); | ||
| }); | ||
|
|
||
| it('settles as unknown when aborted', async () => { | ||
| const controller = new AbortController(); | ||
|
|
||
| const verdict = probe(fakeMediaElement(), 'cache://aborted', 'video', { signal: controller.signal }); | ||
| controller.abort(); | ||
|
|
||
| await expect(verdict).resolves.toBe('unknown'); | ||
| }); | ||
|
|
||
| it('releases the element once it has settled', async () => { | ||
| const element = fakeMediaElement(); | ||
|
|
||
| const verdict = probe(element, 'cache://h264'); | ||
| element.emit('loadedmetadata'); | ||
| await verdict; | ||
|
|
||
| // one load() to start the probe, one after clearing src to release it | ||
| expect(element.loadCalls).toBe(2); | ||
| }); | ||
|
|
||
| it('remembers a definite verdict and does not probe the same file again', async () => { | ||
| const element = fakeMediaElement(4); | ||
| const first = probe(element, 'cache://hevc'); | ||
| element.emit('error'); | ||
| await expect(first).resolves.toBe('unsupported'); | ||
|
|
||
| const createElement = jest.fn(); | ||
| await expect(probeMediaPlayability('cache://hevc', 'video', { createElement })).resolves.toBe('unsupported'); | ||
| expect(createElement).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('probes again after an unknown verdict', async () => { | ||
| const first = fakeMediaElement(2); | ||
| const firstVerdict = probe(first, 'cache://flaky'); | ||
| first.emit('error'); | ||
| await expect(firstVerdict).resolves.toBe('unknown'); | ||
|
|
||
| const second = fakeMediaElement(); | ||
| const secondVerdict = probe(second, 'cache://flaky'); | ||
| second.emit('loadedmetadata'); | ||
| await expect(secondVerdict).resolves.toBe('playable'); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.