[CHIA-4389] Enabled to choose port to run GUI - #2950
Open
ChiaMineJP wants to merge 3 commits into
Open
Conversation
Contributor
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e7196a6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowed to set port from env. Only effective in dev.
Note
Low Risk
Dev-only URL and webpack devServer port wiring; no production load path or security-sensitive logic changes.
Overview
Development GUI port is no longer fixed at 3000. Set
CHIA_GUI_PORT(env orpackages/gui/.envvia webpack’s newdotenvload) and both the React webpack dev server and the Electron devloadURLuse that port, with 3000 as the fallback.Production builds are unchanged: Electron still loads the packaged
file://renderer.Reviewed by Cursor Bugbot for commit e7196a6. Bugbot is set up for automated code reviews on this repo. Configure here.