ci: retry faucet funding with a new wallet - #1752
Merged
Merged
Conversation
The testneta faucet will not pay the same address twice. If coins never arrive after the existing 10-minute wait, delete the key, restart wallet and datalayer, and request funding again, up to three wallets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/ci-faucet.shinstead of 11 copied Faucet steps.Test plan
Note
Low Risk
CI-only workflow and script changes; no application runtime impact, though live-API job reliability depends on the new retry/stop logic behaving correctly.
Overview
Live-API GitHub Actions jobs no longer embed duplicate Faucet bash in tests.yaml; each Faucet step now sets
TESTNETA_FAUCETand runsscripts/ci-faucet.sh.The script keeps the previous behavior (wallet readiness, up to five faucet HTTP attempts, then up to ~10 minutes of balance polling) and adds up to three wallet attempts: if funds never arrive, it stops wallet/data/data_layer_http, deletes keys, generates a new labeled wallet, restarts services, and requests faucet funds again—because the testnet faucet won’t pay the same address twice.
Reviewed by Cursor Bugbot for commit 18f5ab3. Bugbot is set up for automated code reviews on this repo. Configure here.