chore: drop unused chai-http and socket.io-client devDependencies - #1746
Merged
Conversation
Their only consumers were tests/utils/request-utils.js and tests/resources/updates.spec.js, both removed in the preceding v1 test cleanup. A repo-wide search finds no remaining reference to chai-http, chai.request, or socket.io-client outside the lockfile and the stale oss-attribution snapshot. The runtime socket.io dependency used by src/server.js is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1745, which deleted the last consumers of both packages.
Based on
test/v1-cleanup-redundant-specsrather thanv2-rc2, because thedependencies are still in use on
v2-rc2— removing them there would break thesuite. GitHub will retarget this to
v2-rc2automatically once #1745 merges.Merge #1745 first.
Why these two
chai-http— only consumer wastests/utils/request-utils.js, a helper withzero importers. HTTP assertions everywhere else in the suite go through
supertest, which stays.socket.io-client— only consumer wastests/resources/updates.spec.js,socket.io library boilerplate that never imported CADT code.
A repo-wide search (excluding
node_modulesandpackage-lock.json) finds noremaining reference to
chai-http,chai.request, orsocket.io-client.The runtime
socket.iodependency used bysrc/server.jsis untouched.Lockfile
npm uninstall --save-devproduced deletions only — no version churn on anyother package. Sixteen entries drop out,
chai-httpandsocket.io-clientplustheir exclusive transitives:
@types/cookiejar,@types/methods,@types/superagent,chai-http,charset,clone-regexp,convert-hrtime,engine.io-client,function-timeout,ip-regex,is-ip,is-regexp,socket.io-client,super-regex,time-span,xmlhttprequest-sslVerification
npm cifrom the regenerated lockfile succeeds, sopackage.jsonandpackage-lock.jsonagreenpm run test:v1— 153 passing, 5 pendingnpm run test:v2— 1751 passingpackage.jsonandpackage-lock.jsonparse as valid JSONNote
oss-attribution/attributions.txtstill listssocket.io-client, but that fileis a stale generated snapshot — it records both
socket.ioandsocket.io-clientat 4.5.1 whilepackage.jsonpins^4.8.3. It is clearlyregenerated out of band rather than per-PR, so it is left alone here.
Note
Low Risk
Dev-only dependency cleanup with no runtime or test-code changes; packages had no remaining importers.
Overview
Removes unused
chai-httpandsocket.io-clientfromdevDependenciesafter their last consumers were deleted.Also drops their exclusive transitive packages from the lockfile. Runtime
socket.iois unchanged; HTTP tests continue to usesupertest.Reviewed by Cursor Bugbot for commit 126dafb. Bugbot is set up for automated code reviews on this repo. Configure here.