Catch up v2-rc2 to develop branch - #1718
Merged
Merged
Conversation
The sample reverse proxy is expected to carry CADT Socket.IO traffic as well as ordinary HTTP API requests. Forward the upgrade headers so clients can connect through the documented nginx path.
RC Release
fix: proxy websocket upgrades in nginx sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Docs-only nginx config change; low blast radius but misconfiguration could break live WebSocket features behind the proxy.
Overview
Nginx reverse proxy for the CADT API (
localhost:31310) now supports WebSocket upgrades on the rootlocation /block.A
mapon$http_upgradesets$connection_upgradetoupgradeorclose, and the proxy uses HTTP/1.1 withUpgradeandConnectionheaders forwarded—standard pattern so WebSocket traffic is not broken when clients connect through nginx instead of directly to the API.Reviewed by Cursor Bugbot for commit 3156e06. Bugbot is set up for automated code reviews on this repo. Configure here.